Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add OwnerReference GC behavior test #463

Merged
merged 2 commits into from
Sep 15, 2018

Conversation

njhale
Copy link
Member

@njhale njhale commented Sep 15, 2018

Description

Adds an e2e test on OwnerReference behavior to ensure a resource with multiple OwnerReferences will not be garbage collected when one of its owners has been deleted.

Test Case:

CSV-A     CSV-B                             CSV-B
   \       /        ---delete CSV-A--->       |
   ConfigMap		                  ConfigMap

Motivation

OLM can make use of this expected behavior to drive features like managed resource adoption in self-hosted upgrades, permission management in CSV upgrades, etc. Currently, there is a lack of Kubernetes documentation on the effect multiple OwnerReferences have on garbage collection. This test is required ensure OwnerReferences interact with garbage collection as we expect.

- Adds AddOwner function with blocking parameters to ownerutil
- Adds OwnerReference GC behavior test
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is great!

@njhale njhale merged commit a6f305d into operator-framework:master Sep 15, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
test(e2e): add OwnerReference GC behavior test
@njhale njhale deleted the test-ownerref-gc branch September 30, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants