Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operatorclient): remove wait for deployment rollout #422

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

njhale
Copy link
Member

@njhale njhale commented Aug 16, 2018

Description

Removes infinite wait for deployment rollout and allows transitionCSVState(...) to handle deployment status checks.

Removes infinite wait for deployment rollout. transitionCSVState(...)
handles deployment status checks.
@njhale njhale requested review from ecordell and alecmerdler August 16, 2018 23:00
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pipeline is passing and tested manually on CI to make sure this didn't slow anything down 👍

@njhale njhale merged commit 573049f into operator-framework:master Aug 17, 2018
njhale added a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
…monitoring

fix(operatorclient): remove wait for deployment rollout
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…monitoring

fix(operatorclient): remove wait for deployment rollout
@njhale njhale deleted the fix-deployment-monitoring branch September 30, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants