Tests for Runaway Control Loops #361
Conversation
alecmerdler
added
the
internal/tracked
test/e2e/csv_e2e_test.go
Outdated
| @@ -116,6 +116,12 @@ var csvReplacingChecker = func(csv *v1alpha1.ClusterServiceVersion) bool { | |||
| return csv.Status.Phase == v1alpha1.CSVPhaseReplacing || csv.Status.Phase == v1alpha1.CSVPhaseDeleting | |||
| } | |||
|
|
|||
| var csvResourceVersionCheckerFor = func(csv *v1alpha1.ClusterServiceVersion) csvConditionChecker { | |||
| return func(fetchedCSV *v1alpha1.ClusterServiceVersion) bool { | |||
| return csv.GetResourceVersion() == fetchedCSV.GetResourceVersion() | |||
There was a problem hiding this comment.
@ecordell what do you think of this approach to catching regressions like this?
There was a problem hiding this comment.
This will work if we're careful to use it correctly. Calling it twice in a row probably won't find the issues, but calling it once, waiting for a period of time that we don't expect changes to have occurred, and then calling it again will.
There was a problem hiding this comment.
Whenever we hit a known state that we don't expect to change, we could just go ahead and defer a check for the resourceVersion.
If that's not enough, we could keep a registry of resourceVersionChecks for the entire testsuite, and then check them as a final test.
alecmerdler
force-pushed
the
ALM-581
branch
9 times, most recently
from
3e008a2 to
682d2ab
Compare
|
@ecordell The last test run passed, I just removed the |
Tests for Runaway Control Loops
Tests for Runaway Control Loops
Description
Adds checks in the e2e tests to ensure that the Operators are not rapidly processing OLM custom resources.
Addresses https://jira.coreos.com/browse/ALM-581