Add installPlanApproval to Subscription-v1 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
reviewed
May 10, 2018
|
|
||
| // GetInstallPlanApproval gets the configured install plan approval or the default | ||
| func (s *Subscription) GetInstallPlanApproval() v1alpha1.Approval { | ||
| if s.Spec.InstallPlanApproval == v1alpha1.ApprovalManual { |
There was a problem hiding this comment.
I know this works now because there are only 2 possible values, but it should really be:
if s.Spec.InstallPlanApproval == nil {
return v1alpha1.ApprovalAutomatic
}
return s.Spec.InstallPlanApprovalThere was a problem hiding this comment.
I did it this way so that any invalid approvals (approval: foo etc) will get defaulted to Automatic. If we ever get to more than two approval types I would change this to set logic (if approval not in set_of_allowed_values, return default)
ecordell
force-pushed
the
subscription-approvalmode
branch
6 times, most recently
from
965605e to
455f15c
Compare
Setting installPlanApproval on the subscription directs OLM to create installPlans with the specified approval mode (Automatic or Manual)
ecordell
force-pushed
the
subscription-approvalmode
branch
3 times, most recently
from
ada40fb to
62b2ef4
Compare
ecordell
force-pushed
the
subscription-approvalmode
branch
from
62b2ef4 to
51fd078
Compare
alecmerdler
previously approved these changes
May 11, 2018
ecordell
force-pushed
the
subscription-approvalmode
branch
6 times, most recently
from
83616a7 to
fea0ca3
Compare
ecordell
force-pushed
the
subscription-approvalmode
branch
from
fea0ca3 to
0105bac
Compare
alecmerdler
approved these changes
May 12, 2018
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
…approvalmode Add installPlanApproval to Subscription-v1
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…approvalmode Add installPlanApproval to Subscription-v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installPlanApprovalfield on Subscription will dictate theapprovalfield of the InstallPlans that get created by the Subscription.Also removed the
Upgrade-Onlyenum option, until we decide that it's valuable and implement it.