test validate service broker api version function #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
reviewed
May 8, 2018
| err := mockALMBroker(ctrl).ValidateBrokerAPIVersion("n/a") | ||
| require.EqualError(t, err, "not implemented") | ||
| // test bad version | ||
| brokerMock := mockALMBroker(ctrl) |
There was a problem hiding this comment.
Can these be done without the operatorclient mocks? It's just more work to remove operator client if we use them in new code
There was a problem hiding this comment.
These use whatever is in the generated clientsets:
https://github.com/operator-framework/operator-lifecycle-manager/pull/345/files/d9dd9c928c52c1d3c32ff2a9cff4717f63da804e#diff-3a028458a1ff8c8a41758933f6670271L9
Do those need to be updated?
There was a problem hiding this comment.
nope, that's good - I just saw mock and assumed it was using the MockOperatorClient!
ericavonb
force-pushed
the
ALM-538/listcatalog
branch
from
d9dd9c9 to
d72a161
Compare
ericavonb
changed the title
ericavonb
force-pushed
the
ALM-538/listcatalog
branch
from
d72a161 to
09c9908
Compare
ecordell
requested changes
May 8, 2018
| testNamespace = "testns" | ||
| ) | ||
|
|
||
| func mockALMBroker(ctrl *gomock.Controller) *ALMBroker { |
There was a problem hiding this comment.
you can remove ctrl, it's unused
| } | ||
|
|
||
| func TestValidateBrokerAPIVersion(t *testing.T) { | ||
| ctrl := gomock.NewController(t) |
There was a problem hiding this comment.
same here, you don't need ctrl or the defer
ericavonb
force-pushed
the
ALM-538/listcatalog
branch
from
fcd9672 to
f2f9847
Compare
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
…catalog test validate service broker api version function
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…catalog test validate service broker api version function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test of the implementation to validate supported versions of the Open Service Broker as per the service broker interface. All current versions (2.11, 2.12, and 2.13) are supported.