Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased OSB backbone #342

Merged
merged 25 commits into from
May 8, 2018
Merged

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented May 4, 2018

See: #299

@ecordell ecordell force-pushed the rebase-osb branch 3 times, most recently from a2edc3e to 4a9d9bb Compare May 4, 2018 16:47
@ecordell ecordell force-pushed the rebase-osb branch 6 times, most recently from 44ac84d to 393c36f Compare May 4, 2018 17:38
@ecordell ecordell force-pushed the rebase-osb branch 4 times, most recently from 970957b to a7ace4f Compare May 4, 2018 20:04
alecmerdler
alecmerdler previously approved these changes May 7, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ericavonb ericavonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit on the makefile, but otherwise the changes lgtm!

Makefile Outdated
. ./scripts/package-release.sh ver=1.0.0-local Documentation/install/resources Documentation/install/local-values.yaml
build: $(CMDS)

$(CMDS): .FORCE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete the builds to trigger a rebuild, you like you can add clean as a pre-req to any target that you want to have a full rebuild for.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried make clean build in the dockerfiles and it was still saying nothing to build? not sure if I was doing something wrong

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hu. I don't know. That works for me locally. There's always make clean && make build in the Dockerfile. I was thinking like having build: clean $(CMDS), then make build should rebuild.

alecmerdler
alecmerdler previously approved these changes May 8, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit f7eeabd into operator-framework:master May 8, 2018
@ecordell ecordell deleted the rebase-osb branch May 9, 2018 17:39
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants