-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased OSB backbone #342
Rebased OSB backbone #342
Conversation
a2edc3e
to
4a9d9bb
Compare
also conditionally generates servicebroker resources
44ac84d
to
393c36f
Compare
970957b
to
a7ace4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit on the makefile, but otherwise the changes lgtm!
Makefile
Outdated
. ./scripts/package-release.sh ver=1.0.0-local Documentation/install/resources Documentation/install/local-values.yaml | ||
build: $(CMDS) | ||
|
||
$(CMDS): .FORCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete the builds to trigger a rebuild, you like you can add clean
as a pre-req to any target that you want to have a full rebuild for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried make clean build
in the dockerfiles and it was still saying nothing to build
? not sure if I was doing something wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hu. I don't know. That works for me locally. There's always make clean && make build
in the Dockerfile. I was thinking like having build: clean $(CMDS)
, then make build
should rebuild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rebased OSB backbone
Rebased OSB backbone
See: #299