Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics) Report subscription channel #1100

Merged
merged 1 commit into from
Nov 1, 2019
Merged

feat(metrics) Report subscription channel #1100

merged 1 commit into from
Nov 1, 2019

Conversation

awgreene
Copy link
Member

This commit introduces a change that updates the sucription_sync_total
metric to include a channel

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2019
@awgreene awgreene force-pushed the increase-cardinality-on-csv-metrics branch 3 times, most recently from dd27cc0 to 004a94e Compare October 31, 2019 11:18
@awgreene
Copy link
Member Author

/retest

ecordell
ecordell approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2019
@ecordell
Copy link
Member

/retest

@awgreene
feat(metrics) Report subscription channel
eb6b0f8 
This commit introduces a change that updates the sucription_sync_total
metric to include a channel label.
@awgreene awgreene force-pushed the increase-cardinality-on-csv-metrics branch from 004a94e to eb6b0f8 Compare November 1, 2019 10:11
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@awgreene
Copy link
Member Author

awgreene commented Nov 1, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Nov 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1878972 into operator-framework:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awgreene @ecordell @openshift-ci-robot @openshift-merge-robot