Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log message in resolver #1085

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fix log message in resolver #1085

merged 2 commits into from
Oct 28, 2019

Conversation

ecordell
Copy link
Member

This was masking the actual errors coming from the step generator

Description of the change:

Fixes an issue with the logs - actual errors were being masked instead of wrapped.

Motivation for the change:

Debugging a failing operator step generation.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@ecordell
Fix log message in resolver
959a886 
This was masking the actual errors coming from the step generator
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2019
@kevinrizza
Copy link
Member

lgtm

@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member

/retest

5 similar comments
@dinhxuanvu
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member

/retest

@dinhxuanvu
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3a31383 into master Oct 28, 2019
@ecordell ecordell deleted the ecordell-fix-logs branch October 1, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu requested changes

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ecordell @kevinrizza @dinhxuanvu @openshift-ci-robot @openshift-merge-robot