-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1761924: Update PackageManifest table handler #1078
Bug 1761924: Update PackageManifest table handler #1078
Conversation
After the Kube 1.16 rebase, the `oc get packagemanfiest` command would return an error complaining that no table handler was registered. This is due to the fact that the expected function signature was changed. This commit introduces a change that updates the function signature.
@awgreene: This pull request references Bugzilla bug 1761924, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We can follow up with a test case for this; but we might want to put it in e2e-aws so that we find issues with oc
, etc.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
@awgreene: All pull requests linked via external trackers have merged. Bugzilla bug 1761924 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
After the Kube 1.16 rebase, the
oc get packagemanfiest
command wouldreturn an error complaining that no table handler was registered. This
is due to the fact that the expected function signature was changed.
This commit introduces a change that updates the function signature.