Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1761924: Update PackageManifest table handler #1078

Merged

Conversation

awgreene
Copy link
Member

After the Kube 1.16 rebase, the oc get packagemanfiest command would
return an error complaining that no table handler was registered. This
is due to the fact that the expected function signature was changed.

This commit introduces a change that updates the function signature.

After the Kube 1.16 rebase, the `oc get packagemanfiest` command would
return an error complaining that no table handler was registered. This
is due to the fact that the expected function signature was changed.

This commit introduces a change that updates the function signature.
@openshift-ci-robot
Copy link
Collaborator

@awgreene: This pull request references Bugzilla bug 1761924, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1761924: Update PackageManifest table handler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 16, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2019
@ecordell
Copy link
Member

/retest

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We can follow up with a test case for this; but we might want to put it in e2e-aws so that we find issues with oc, etc.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019
@ecordell
Copy link
Member

/retest

4 similar comments
@awgreene
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@awgreene
Copy link
Member Author

/retest

@ecordell
Copy link
Member

/retest

@ecordell
Copy link
Member

ecordell commented Oct 19, 2019 via email

@awgreene
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 36db200 into operator-framework:master Oct 19, 2019
@openshift-ci-robot
Copy link
Collaborator

@awgreene: All pull requests linked via external trackers have merged. Bugzilla bug 1761924 has been moved to the MODIFIED state.

In response to this:

Bug 1761924: Update PackageManifest table handler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants