Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Operator Discovery #1070

Closed
wants to merge 13 commits into from
Closed

Enable Operator Discovery #1070

wants to merge 13 commits into from

Conversation

njhale
Copy link
Member

@njhale njhale commented Oct 11, 2019

Description of the change:

Add the operators.coreos.com/v2alpha1 API group and Operator resource with component selection.

Note: This must be put behind a feature gate before merging.

njhale added 4 commits October 11, 2019 00:45
@njhale
feat(api): add operator v2alpha1 api
ec9a42a 
- Add Operator type and CRD
- Clean up helm templates (CVO numbering)
@njhale
feat(operator): add controller w/ component selection
47422f8
@njhale
chore(codegen): use controller-runtime for new apis
6368b34 
- Clean up codegen/mockgen make rules
- Clean up codegen/mockgen scripts
- Run codegen and mockgen
@njhale
chore(manifests): update ocp
416ee7b
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2019
@alecmerdler alecmerdler removed their request for review October 11, 2019 05:19
njhale
njhale commented Oct 11, 2019
View reviewed changes
cmd/olm/main.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2019
@njhale njhale force-pushed the operator-discovery branch from 838c278 to 8cf25e1 Compare October 16, 2019 20:19
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2019
@njhale njhale force-pushed the operator-discovery branch 3 times, most recently from ce6cde0 to 6ce7c26 Compare October 18, 2019 21:49
@njhale njhale mentioned this pull request Oct 28, 2019
Closed
@njhale njhale force-pushed the operator-discovery branch 8 times, most recently from 0c0105f to 37f33ff Compare November 1, 2019 21:18
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2019
njhale and others added 2 commits November 1, 2019 20:06
@njhale @ecordell
feat(operator): add operator api
3112b0b
@ecordell
Merge branch 'operator-discovery' of github.com:njhale/operator-lifec…
b038a23 
…ycle-manager into njhale-operator-discovery

# Conflicts:
#	deploy/upstream/quickstart/crds.yaml
#	go.mod
#	go.sum
#	pkg/fakes/fake_registry_store.go
#	vendor/modules.txt
gallettilance
gallettilance approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kevinrizza
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gallettilance, kevinrizza, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ecordell
Copy link
Member

ecordell commented Nov 2, 2019

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Nov 2, 2019
@openshift-ci-robot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@njhale njhale force-pushed the operator-discovery branch 4 times, most recently from 293a70b to ce8ce19 Compare November 3, 2019 22:18
@njhale
Copy link
Member Author

njhale commented Nov 4, 2019

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Nov 4, 2019

/retest

@njhale njhale force-pushed the operator-discovery branch from ce8ce19 to 2cd4186 Compare November 4, 2019 21:10
@openshift-ci-robot
Copy link
Collaborator

@njhale: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 6ce7c26 link /test e2e-aws
ci/prow/e2e-aws-upgrade 6ce7c26 link /test e2e-aws-upgrade
ci/prow/unit 6985aa4 link /test unit
ci/prow/e2e-aws-console-olm 6985aa4 link /test e2e-aws-console-olm
ci/prow/e2e-aws-olm 6985aa4 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale
Copy link
Member Author

njhale commented Dec 23, 2019

We're driving a roughly equivalent feature w/ the k8s cluster-addons WG. Closing this for now.

@njhale njhale closed this Dec 23, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2019
@openshift-ci-robot
Copy link
Collaborator

@njhale: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallettilance gallettilance gallettilance approved these changes

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@kevinrizza kevinrizza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@njhale @kevinrizza @openshift-ci-robot @ecordell @gallettilance