Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release) Update changelog #1051

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

awgreene
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 27, 2019
@awgreene
Copy link
Member Author

/retest

@jpeeler
Copy link

jpeeler commented Sep 27, 2019

I'd expect to see only appends. Why are deletions happening?

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2019
@awgreene
Copy link
Member Author

I'd expect to see only appends. Why are deletions happening?

Good question @jpeeler, this was due to the changelog command overwriting the file - I have added the history back to the log.

@jpeeler
Copy link

jpeeler commented Sep 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
@camilamacedo86
Copy link
Contributor

/test e2e-aws-olm

@ecordell
Copy link
Member

/retest

@openshift-ci-robot
Copy link
Collaborator

@awgreene: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm f413a40 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale njhale added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 29, 2019
@njhale
Copy link
Member

njhale commented Sep 29, 2019

@ecordell do we have precedent for merging doc-only changes without waiting for CI to go green?

@ecordell
Copy link
Member

doc-only, merging

@ecordell ecordell merged commit 8e6c86f into operator-framework:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants