Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1727042: Ensure status monitor always reports upgradeable #1007

Conversation

kevinrizza
Copy link
Member

Currently on startup the initial status reporting sets the upgradeable
field. However, because of the way the status monitor builder recreates
the entire status block on every report, we also need to set upgradeable
every time that object is reported.

For now, report that upgradeable is always true as long as nothing is in
a degraded state.

Pertaining to these bugzillas:
https://bugzilla.redhat.com/show_bug.cgi?id=1727042
https://bugzilla.redhat.com/show_bug.cgi?id=1727032

Currently on startup the initial status reporting sets the upgradeable
field. However, because of the way the status monitor builder recreates
the entire status block on every report, we also need to set upgradeable
every time that object is reported.

For now, report that upgradeable is always true as long as nothing is in
a degraded state.
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 23, 2019
@openshift-ci-robot
Copy link
Collaborator

@kevinrizza: This pull request references Bugzilla bug 1727042, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1727042: Ensure status monitor always reports upgradeable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinrizza
To complete the pull request process, please assign alecmerdler
You can assign the PR to them by writing /assign @alecmerdler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2019
@openshift-ci-robot
Copy link
Collaborator

@kevinrizza: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 43b1e45 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinrizza
Copy link
Member Author

Closing in favor of #989

@kevinrizza kevinrizza closed this Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants