Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add CRD Upgrade Safety Preflight check to the ClusterExtension controller #979

Merged
merged 2 commits into from
Jun 27, 2024

add nil pointer check

06914d2
Select commit
Loading
Failed to load commit list.
Merged

✨ Add CRD Upgrade Safety Preflight check to the ClusterExtension controller #979

add nil pointer check
06914d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 27, 2024 in 0s

76.89% (-2.51%) compared to 208e584

View this Pull Request on Codecov

76.89% (-2.51%) compared to 208e584

Details

Codecov Report

Attention: Patch coverage is 26.98413% with 46 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (208e584) to head (06914d2).

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 4.00% 23 Missing and 1 partial ⚠️
...nternal/controllers/clusterextension_controller.go 38.70% 15 Missing and 4 partials ⚠️
cmd/manager/main.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   79.40%   76.89%   -2.51%     
==========================================
  Files          17       17              
  Lines        1170     1225      +55     
==========================================
+ Hits          929      942      +13     
- Misses        165      201      +36     
- Partials       76       82       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov