Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ WIP: DO NOT MERGE: Shift Week Prototypes #1418

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Oct 30, 2024

Description

  • Direct bundle install
  • Parameter passing with schema validation in ClusterExtension
  • Parameterizing registry+v1 bundles by converting to helm charts with values.schema.json
  • CLI to convert registry+v1 bundle to helm chart
  • CLI to convert helm chart repo to an FBC catalog
  • Support for bundles that require webhooks
  • Incorporate new conversion and plumbing of values into the operator-controller's Helm applier that is used to install content.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner October 30, 2024 21:32
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d0801a5
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/672e77dae9318800082f4bf3
😎 Deploy Preview https://deploy-preview-1418--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford joelanford force-pushed the shift-week branch 2 times, most recently from 76b196f to a616db6 Compare October 31, 2024 04:34
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 69.44600% with 546 lines in your changes missing coverage. Please review.

Project coverage is 73.11%. Comparing base (d0865da) to head (d0801a5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/rukpak/convert/v2/registryv1.go 86.52% 112 Missing and 56 partials ⚠️
cmd/chartrepo-to-catalog/main.go 0.00% 100 Missing ⚠️
internal/values/values.go 10.84% 71 Missing and 3 partials ⚠️
api/v1alpha1/zz_generated.deepcopy.go 1.81% 52 Missing and 2 partials ⚠️
internal/resolve/bundle.go 0.00% 46 Missing ⚠️
cmd/registryv1-to-helm/main.go 0.00% 32 Missing ⚠️
...kpak/convert/v2/internal/parametrize/mergeblock.go 54.16% 15 Missing and 7 partials ⚠️
internal/rukpak/convert/registryv1.go 27.77% 11 Missing and 2 partials ⚠️
...al/rukpak/convert/v2/internal/parametrize/block.go 81.69% 9 Missing and 4 partials ⚠️
internal/applier/helm.go 42.85% 9 Missing and 3 partials ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1418      +/-   ##
==========================================
- Coverage   75.18%   73.11%   -2.07%     
==========================================
  Files          42       51       +9     
  Lines        3236     5011    +1775     
==========================================
+ Hits         2433     3664    +1231     
- Misses        632     1095     +463     
- Partials      171      252      +81     
Flag Coverage Δ
e2e 45.82% <42.59%> (-6.46%) ⬇️
unit 61.22% <67.26%> (+3.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford force-pushed the shift-week branch 3 times, most recently from b11d190 to db2b962 Compare October 31, 2024 18:31
@joelanford joelanford changed the title WIP: DO NOT MERGE: Shift Week Prototypes ✨ WIP: DO NOT MERGE: Shift Week Prototypes Oct 31, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@joelanford joelanford added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024
@joelanford joelanford force-pushed the shift-week branch 2 times, most recently from 0f712c0 to 49704d8 Compare November 3, 2024 02:42
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 8, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants