Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Replace separator in NotSatisfiable error #158

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 13, 2023

Use new line instead of comma as a separator.

Example from operator-controller as yaml:

status:
  conditions:
  - lastTransitionTime: "2023-11-13T13:43:28Z"
    message: |-
      constraints not satisfiable:
      argocd-operator package uniqueness permits at most 1 of operatorhubio-argocd-operator-argocd-operator.v0.6.0, operatorhubio-argocd-operator-argocd-operator.v0.4.0
      installed package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.4.0
      installed package argocd-operator is mandatory
      required package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.6.0
      required package argocd-operator is mandatory
    observedGeneration: 2
    reason: ResolutionFailed
    status: "False"
    type: Resolved

And as json:

{
    "status": {
        "conditions": [
            {
                "lastTransitionTime": "2023-11-13T13:43:28Z",
                "message": "constraints not satisfiable:\nargocd-operator package uniqueness permits at most 1 of operatorhubio-argocd-operator-argocd-operator.v0.6.0, operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.4.0\ninstalled package argocd-operator is mandatory\nrequired package argocd-operator requires at least one of operatorhubio-argocd-operator-argocd-operator.v0.6.0\nrequired package argocd-operator is mandatory",
                "observedGeneration": 2,
                "reason": "ResolutionFailed",
                "status": "False",
                "type": "Resolved"
            }
        ]
    }
}

Closes #150

Use new line instead of comma as a separator.

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a012d2) 65.45% compared to head (3135de7) 65.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files          11       11           
  Lines         495      495           
=======================================
  Hits          324      324           
  Misses        152      152           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review November 13, 2023 13:32
@m1kola m1kola requested a review from a team as a code owner November 13, 2023 13:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@m1kola m1kola changed the title Replace separator in NotSatisfiable error ✨ Replace separator in NotSatisfiable error Nov 13, 2023
@m1kola m1kola marked this pull request as draft November 13, 2023 13:39
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@m1kola m1kola marked this pull request as ready for review November 13, 2023 13:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help a lot with readability!

@everettraven everettraven added this pull request to the merge queue Nov 13, 2023
Merged via the queue into operator-framework:main with commit ddaf504 Nov 13, 2023
7 checks passed
@m1kola m1kola deleted the change_separator branch November 14, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace commas in error messages
3 participants