-
Notifications
You must be signed in to change notification settings - Fork 558
Add community Eclipse Che operator (for downstream operators) #384
Add community Eclipse Che operator (for downstream operators) #384
Conversation
There was still one unanswered question in the previous PR (superseded by this one): #280 (comment) To summarize: One of the possible settings in a As @dmesser suggested, there are 2 options here:
@l0rd @slemeur @nickboldt wdyt ? |
@davidfestal for option 2 it's not clear what happens if the users doesn't change any config and try to deploy on plain k8s: is the operator going to fail or will it figure out that there is no OpenShift oAuth and adapt the deployment to the underlying infrastructure? If it fails I would rather go with option 1 because that's the community operator: most of the deployments will happen on plain k8s and the default configuration should reflect that (k8s first). |
@l0rd This PR is for Openshift only. The corresponding PR for plain K8s doesn't even have the explanation about the additional requirements, because it has no sense. |
@davidfestal Can you please rebase and squash your commits? |
c13f98e
to
6f961d2
Compare
* Add repository URL to annotations * Upgrade to `beta-5.0` * Rename the CSV to be OperatorHub-compliant Signed-off-by: David Festal <[email protected]>
6f961d2
to
50d008d
Compare
@davidfestal: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is a followup of PR #280 that only focuses on the
community-operators
addition, as requested by comment #280 (comment)This PR adds Eclipse Che operator to community operators. Eclipse Che operator auto-detects infra, so can run on vanilla k8s and OpenShift.
Tested on 4.0.0-0.9