-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adding Availability enum to catalog spec #421
✨ Adding Availability enum to catalog spec #421
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 37.31% 38.36% +1.05%
==========================================
Files 15 15
Lines 922 941 +19
==========================================
+ Hits 344 361 +17
- Misses 529 530 +1
- Partials 49 50 +1 ☔ View full report in Codecov by Sentry. |
401f2d0
to
9b9a7af
Compare
8326637
to
650c934
Compare
b5245a5
to
5cbabe2
Compare
Signed-off-by: Lalatendu Mohanty <[email protected]>
5cbabe2
to
eba52e7
Compare
Looking pretty good. Can you also add some tests? I'm thinking primarily focused on unit tests, but also an e2e that sets up a catalog as "Enabled", then disables it, and checks that:
|
a72fc12
to
6cd0ea3
Compare
Signed-off-by: Lalatendu Mohanty <[email protected]>
6cd0ea3
to
70a5536
Compare
Implementation looks good to me! Are you planning to add tests to this PR? |
yeah, working on that. Will remove the WIP attached to the PR once that is done. |
34af72b
to
b6c304c
Compare
Signed-off-by: Lalatendu Mohanty <[email protected]>
b6c304c
to
a3281bf
Compare
This is a follow-up from the previous PR operator-framework#421 i.e. commit d320249 Signed-off-by: Lalatendu Mohanty <[email protected]>
No description provided.