Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adding Availability enum to catalog spec #421

Merged

Conversation

LalatenduMohanty
Copy link
Member

No description provided.

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner October 3, 2024 11:26
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.36%. Comparing base (b1b145a) to head (a3281bf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   37.31%   38.36%   +1.05%     
==========================================
  Files          15       15              
  Lines         922      941      +19     
==========================================
+ Hits          344      361      +17     
- Misses        529      530       +1     
- Partials       49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LalatenduMohanty LalatenduMohanty force-pushed the Add_disabled_field branch 2 times, most recently from 8326637 to 650c934 Compare October 10, 2024 19:50
@LalatenduMohanty LalatenduMohanty force-pushed the Add_disabled_field branch 3 times, most recently from b5245a5 to 5cbabe2 Compare October 15, 2024 06:49
@joelanford
Copy link
Member

Looking pretty good. Can you also add some tests? I'm thinking primarily focused on unit tests, but also an e2e that sets up a catalog as "Enabled", then disables it, and checks that:

  1. you get a 404 from the webserver for the content
  2. all of the status fields are updated appropriately
  3. the finalizer is removed

cmd/manager/main.go Outdated Show resolved Hide resolved
@LalatenduMohanty LalatenduMohanty force-pushed the Add_disabled_field branch 2 times, most recently from a72fc12 to 6cd0ea3 Compare October 16, 2024 14:58
@joelanford
Copy link
Member

Implementation looks good to me! Are you planning to add tests to this PR?

@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Oct 16, 2024

Implementation looks good to me! Are you planning to add tests to this PR?

yeah, working on that. Will remove the WIP attached to the PR once that is done.

Signed-off-by: Lalatendu Mohanty <[email protected]>
@LalatenduMohanty LalatenduMohanty changed the title ⚠️ [WIP] Adding Availability enum to catalog spec ⚠️ Adding Availability enum to catalog spec Oct 16, 2024
@LalatenduMohanty LalatenduMohanty changed the title ⚠️ Adding Availability enum to catalog spec ⚠️ [WIP] Adding Availability enum to catalog spec Oct 16, 2024
@LalatenduMohanty LalatenduMohanty changed the title ⚠️ [WIP] Adding Availability enum to catalog spec ✨ Adding Availability enum to catalog spec Oct 17, 2024
@joelanford joelanford added this pull request to the merge queue Oct 17, 2024
Merged via the queue into operator-framework:main with commit d320249 Oct 17, 2024
16 checks passed
LalatenduMohanty added a commit to LalatenduMohanty/catalogd that referenced this pull request Oct 25, 2024
This is a follow-up from the previous PR operator-framework#421 i.e. commit d320249

Signed-off-by: Lalatendu Mohanty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants