-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new validator for deprecate images #380
Add new validator for deprecate images #380
Conversation
This validator will help us to warning users about the usage of deprecated images found in the CSV
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 39.79% 39.98% +0.19%
==========================================
Files 56 57 +1
Lines 5450 5484 +34
==========================================
+ Hits 2169 2193 +24
- Misses 3127 3136 +9
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. |
|
||
// DeprecatedImages contains a list of deprecated images and their respective messages | ||
var DeprecatedImages = map[string]string{ | ||
"gcr.io/kubebuilder/kube-rbac-proxy": "Your bundle uses the image `gcr.io/kubebuilder/kube-rbac-proxy`. This upstream image is deprecated and may become unavailable at any point. \n\nPlease use an equivalent image from a trusted source or update your approach to protect the metrics endpoint. \n\nFor further information: https://github.com/kubernetes-sigs/kubebuilder/discussions/3907", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It allows us add more images/messages in the future if we need to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ^^ thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I think it will not fly :-( |
closing as not accepted. |
This validator will help us to warning users about the usage of deprecated images found in the CSV