Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new validator for deprecate images #380

Conversation

camilamacedo86
Copy link
Contributor

This validator will help us to warning users about the usage of deprecated images found in the CSV

This validator will help us to warning users about the usage of deprecated images found in the CSV
@openshift-ci openshift-ci bot requested review from exdx and joelanford December 9, 2024 08:53
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 39.98%. Comparing base (a4a9bfd) to head (dd879d8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/validation/internal/deprecated_images.go 70.58% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   39.79%   39.98%   +0.19%     
==========================================
  Files          56       57       +1     
  Lines        5450     5484      +34     
==========================================
+ Hits         2169     2193      +24     
- Misses       3127     3136       +9     
- Partials      154      155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


// DeprecatedImages contains a list of deprecated images and their respective messages
var DeprecatedImages = map[string]string{
"gcr.io/kubebuilder/kube-rbac-proxy": "Your bundle uses the image `gcr.io/kubebuilder/kube-rbac-proxy`. This upstream image is deprecated and may become unavailable at any point. \n\nPlease use an equivalent image from a trusted source or update your approach to protect the metrics endpoint. \n\nFor further information: https://github.com/kubernetes-sigs/kubebuilder/discussions/3907",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows us add more images/messages in the future if we need to do so

Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^ thank you!

Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@camilamacedo86
Copy link
Contributor Author

/hold

I think it will not fly :-(
Not everybody was onboarding with the idea

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@camilamacedo86
Copy link
Contributor Author

closing as not accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants