Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: Re-bump opentelemetry to v1.20.0 #310

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

joelanford
Copy link
Member

This was bumped originally in #309, but we accidentally reverted it in #292. Just putting the opentelemetry (and related) versions back to where we expect them to be.

@openshift-ci openshift-ci bot requested review from awgreene and grokspawn January 10, 2024 13:59
Copy link

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ffba44) 42.64% compared to head (e1d795c) 42.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   42.64%   42.64%           
=======================================
  Files          42       42           
  Lines        3583     3583           
=======================================
  Hits         1528     1528           
  Misses       1903     1903           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0d032b9 into operator-framework:master Jan 10, 2024
6 checks passed
@acornett21
Copy link
Contributor

@joelanford I don't feel like this is the best way to manage this. If this project is manually updating indirect dependencies, contributors aren't going to know that, and the same mistake will happen again. Should a required sections be added for these indirects which have been changed manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants