Catch whitespace csv.spec.provider.name values

[komish]

This PR addresses cases where bundle validate fails to catch a provider.name value of " " as an empty value.

This solution trims whitespace for the value before evaluating for emptiness to address this case.

Signed-off-by: Jose R. Gonzalez [email protected]

[komish]

This issue was discovered here -> redhat-openshift-ecosystem/community-operators-prod#1869

[tedhtchang]

@komish Curious how does this PR affect operator-sdk bundle validate command, or CI test suites(kiwi, lemo, orange), or the OLM operator?

[komish]

@tedhtchang bundle validate policy intends to prevent an empty provider name, but a value containing space characters and no other characters is not being treated as an empty value.

I can’t speak to the rest of the cases.

[acornett21]

@J0zi or @mvalarh Do any of the community operators CI tests validate the content of the bundle? Or do you all rely on operator-sdk bundle validate directly to do the validation of the CSV? I believe CI tests reply on operator-sdk but I am not 100% certain.

[J0zi]

@acornett21 we rely on operator-sdk validation functionalities.

[perdasilva]

lgtm

[joelanford]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment