Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow COG_PIPELINE_TIMEOUT to set the timeout at runtime #1399

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

nmohoric
Copy link
Member

Simple change to at least allow a flexible global pipeline command timeout at runtime.

This is a minor part of #1283 but that ticket will need to be revisited with a full planning of how to implement the real feature.

Copy link
Member

@ohaiwalt ohaiwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great first step.

@ohaiwalt
Copy link
Member

ohaiwalt commented Aug 29, 2017

Any thoughts on where we could add this to the docs?

Additionally, it looks like this branch was pulled off before the changes to disable Hipchat tests landed. You may want to rebase.

@nmohoric
Copy link
Member Author

nmohoric commented Sep 3, 2017

Rebased this and also added minor documentation at operable/cog-book#94

@davejlong davejlong merged commit 79e9f02 into master Sep 15, 2017
@nmohoric nmohoric deleted the nmohoric/env_timeout branch December 14, 2017 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants