Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

organize self-service invitation doc #750

Merged
merged 2 commits into from
Sep 26, 2024
Merged

organize self-service invitation doc #750

merged 2 commits into from
Sep 26, 2024

Conversation

qrkourier
Copy link
Member

@qrkourier qrkourier commented Sep 16, 2024 •
edited
Loading

Organize the invitation doc content to:

  1. promote myzrok.io for NetFoundry instance users
  2. minimize the getting started article
  3. reduce confusion about how to create an account

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zrok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 2:46pm

@qrkourier qrkourier marked this pull request as ready for review September 16, 2024 12:40
michaelquigley
michaelquigley requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this documentation makes sense without the "generating an invitation" section preceding the "enabling your environment" section.

@qrkourier
Copy link
Member Author

@michaelquigley Please let me know if the follow-up commit answered your concern about it making sense.

michaelquigley
michaelquigley approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@michaelquigley michaelquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the docs are turning into a bit of a maze, but I don't know that I'm going to have any feedback that's actionable in the short term.

@qrkourier qrkourier merged commit 76c67c3 into main Sep 26, 2024
5 checks passed
@qrkourier qrkourier deleted the organize-invite-doc branch September 26, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelquigley michaelquigley michaelquigley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qrkourier @michaelquigley