Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routers should consider control channels unresponsive if they are not connected #2171

Closed
plorenz opened this issue Jun 28, 2024 · 1 comment
Closed

Routers should consider control channels unresponsive if they are not connected #2171

plorenz opened this issue Jun 28, 2024 · 1 comment
Assignees
@plorenz
Labels
bug Something isn't working router Issue relates to the router

Comments

@plorenz
Copy link
Member

plorenz commented Jun 28, 2024

right now unresponsive is measured purely off of latency measurements. That logic can consider an unconnected control channel responsive if the channel was disconnected after a latency response is received and before the next one is sent.
@plorenz plorenz self-assigned this Jun 28, 2024
@plorenz plorenz closed this as completed in aaa26b7 Jul 1, 2024
plorenz added a commit that referenced this issue Jul 1, 2024
@plorenz
Merge pull request #2172 from openziti/fix-router-unresponsive-check
60eeed1 
Mark ctrl chan as unresponsive if disconnected. Fixes #2171
@plorenz
Copy link
Member Author

plorenz commented Jul 11, 2024

reopening, as previous fix was incorrect

@plorenz plorenz reopened this Jul 11, 2024
@plorenz plorenz added bug Something isn't working router Issue relates to the router labels Jul 11, 2024
plorenz added a commit that referenced this issue Jul 12, 2024
@plorenz
Fix responsive check. Fixes #2171. Add router-connections inspection. F…
28dcbb0 
…ixes #2219. Improve can't load data file log message. Fixes #2195
@plorenz plorenz mentioned this issue Jul 12, 2024
Closed
@plorenz plorenz moved this to In Review in Controller HA Jul 12, 2024
plorenz added a commit that referenced this issue Jul 12, 2024
@plorenz
Fix responsive check. Fixes #2171. Add router-connections inspection. F…
b905b02 
…ixes #2219. Improve can't load data file log message. Fixes #2195
plorenz added a commit that referenced this issue Jul 12, 2024
@plorenz
Fix responsive check. Fixes #2171. Add router-connections inspection. F…
ea109bb 
…ixes #2219. Improve can't load data file log message. Fixes #2195
plorenz added a commit that referenced this issue Jul 12, 2024
@plorenz
Fix responsive check. Fixes #2171. Add router-connections inspection. F…
7d00be8 
…ixes #2219. Improve can't load data file log message. Fixes #2195
plorenz added a commit that referenced this issue Jul 15, 2024
@plorenz
Merge pull request #2220 from openziti/router-ch-fixes
963f5c1 
Fix responsive check. Fixes #2171. Add router-connections inspection. Fixes #2219. Improve can't load data file log message. Fixes #2195
@github-project-automation github-project-automation bot moved this from In Review to Done in Controller HA Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plorenz plorenz

Labels
bug Something isn't working router Issue relates to the router
Projects
Controller HA
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plorenz