Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard route if update is a subnet of tun's address #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomc797
Copy link
Contributor

@tomc797 tomc797 commented Jun 8, 2023

As the tun_ip is derived from dns_block, set the tun's address prefix length equal to dns_block prefix length. Then ignore any route updates that are a subnet of the tun's address. This becomes helpful when large number of DNS intercepts are employed (say wildcard), each causing a /32 route to be added.

@tomc797 tomc797 requested a review from a team as a code owner June 8, 2023 14:16
As the tun_ip is derived from dns_block, set the tun's address prefix
length equal to dns_block prefix length. Then ignore any route updates
that are a subnet of the tun's address. This becomes helpful when large
number of DNS intercepts are employed (say wildcard), each causing a /32
route to be added.

Signed-off-by: Tom Carroll <[email protected]>
@tomc797 tomc797 force-pushed the feature/disregard_route_updates_that_subnet_tun_address branch from 5c50bdd to 87a4f73 Compare June 8, 2023 14:26
@scareything
Copy link
Member

Thanks for taking a stab at this. This has been on our minds for a while now (#474).

Ideally the matching routes would be caught at the tunneler-sdk layer (probably in add_route) so all platforms benefit. Da you have any interest in doing the route detection there? I'd think ziti_address_match would be helpful in the tsdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants