Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/geneve #264

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feature/geneve #264

wants to merge 14 commits into from

Conversation

dariuszSki
Copy link
Contributor

@ekoby and @scareything just wanted to create this PR , so you can officially review the code. I worked with Shawn quite a bit, so he is familiar with it a bit more already. Please review and provide comments. I have tested the modified code and seems to be working fine. The throughput is about 60% of the ZET in my testing using the same network and ERs plus load balance for the geneve case. Obvious question is if you want to support multiple drivers. Let me know what you think and how you would see this enabled if accepted. Thanks!

@dovholuknf
Copy link
Member

@dariuszSki - you found another way of doing this, right? should we keep this PR out here or can we close it?

@qrkourier
Copy link
Member

@dariuszSki Question for you above from Clint.

@dariuszSki
Copy link
Contributor Author

But my original question was not answered? Support of more than one driver mode?

@scareything
Copy link
Member

The only reason not to merge this PR as it exists is because it changes the ZET initialization on Linux to use the geneve driver instead of the tun driver.

Adding a special command line option to select between geneve or tun would be a simple but inelegant solution to that problem. Alternatively, we've been talking and thinking about netif_driver extensions for a while now, and I think this would be a good use of the extension mechanism once it exists. Issues #596 and #597 have been created to track the extension mechanism itself and the implementation of this PR as an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants