-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readmes #46
Update readmes #46
Conversation
… Flazk README, put examples into folders
|
||
## Installation | ||
# Python SDK for OpenZiti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this HTML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely would prefer to see this as markdown. sometimes for images you really need to embed html on the markdown so that you can style an image but most of what I see here should be markdown, not html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get the styling that I wanted (a lot of it simply centering and/or centering inline content), I had to use HTML to get it to work how I wanted. Much of the HTML structure is copied from other READMEs that I drew inspiration from, and I did remove HTML from the copied content wherever possible.
I can revisit the HTML and try to make more of it work as markdown, but it was similar to this image. After a decent amount of effort, I couldn't get the markdown to do what I wanted, and it easily worked as HTML, so I didn't want to waste more time trying to get it to work when it may not have even been possible and worked as is.
No description provided.