Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin-web: Remove filtering of empty spans #53

Closed
wants to merge 1 commit into from
Closed

zipkin-web: Remove filtering of empty spans #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions zipkin-web/app/models/ztrace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ def from_thrift(*args)

def initialize(spans)
@spans = spans
#TODO we have a bug somewhere that sends empty spans. this is to filter those out to avoid breakages
@filtered_spans = spans.find_all {|s| s.annotations.any?}
end

def start_timestamp
Expand Down Expand Up @@ -108,7 +106,7 @@ def span_depths()

def as_json(opts={})
trace_start_time = self.start_timestamp
@filtered_spans.map do |s|
spans.map do |s|
{
:id => s.id,
:name => s.name,
Expand Down