Adds elasticsearch6 and elasticsearch7 images #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used in our integration tests for zipkin-storage/elasticsearch See openzipkin-attic/docker-zipkin#86
|
verified all the things |
|
Does this mean when we attic |
|
yep let them die |
|
I'm only adding in images we use or suggest for testing. we no longer reference 2 and 5 in our integration tests, which is the longer rationale. we should bring the instructive docker-compose files over, including the prometheus demo, but yeah the old ES images can die |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used in our integration tests for zipkin-storage/elasticsearch
See openzipkin-attic/docker-zipkin#86
Tested with
$ cd docker $ DOCKERFILE_PATH=docker/Dockerfile DOCKER_TAG=foo hooks/post_build