Add release dockerfile. #2846
Merged
Add release dockerfile. #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/Dockerfile.release
Outdated
|
|
||
| USER zipkin | ||
|
|
||
| EXPOSE 9410 9411 |
There was a problem hiding this comment.
I think we actually removed thrift from slim
Suggested change
| EXPOSE 9410 9411 | |
| EXPOSE 9411 |
docker/Dockerfile.release
Outdated
|
|
||
| # Use to set heap, trust store or other system properties. | ||
| ENV JAVA_OPTS -Djava.security.egd=file:/dev/./urandom | ||
| # 3rd party modules like zipkin-aws will apply profile settings with this |
There was a problem hiding this comment.
remove this as slim doesn't support it. I know I forgot to remove it upstream :P
| # not work right away if the sync is taking time, followed by bintray, which should always work | ||
| # since it's where we publish to. | ||
|
|
||
| RUN mvn org.apache.maven.plugins:maven-dependency-plugin:get \ |
codefromthecrypt
approved these changes
Oct 16, 2019
This was referenced Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we want our release images to use the same artifacts as published to Maven, we need to have a separate
Dockerfilefor it from the master build. Luckily it's content isn't all that different.I'll reconfigure Docker Hub to use this dockerfile for tag pushes. Then we should be ready to finish the migration.