Adds ActiveMQ 5.x transport #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to popular demand, this adds support for ActiveMQ 5.x. This is enabled when the env variable `ACTIVEMQ_URL` is set to a valid broker. Thanks very much to @IAMTJW for early work towards this change. To try this change, you can use jitpack https://jitpack.io/#openzipkin/zipkin Ex. ```bash TAG=activemq-SNAPSHOT curl -sSL https://jitpack.io/com/github/openzipkin/zipkin/zipkin-server/${TAG}/zipkin-server-${TAG}-exec.jar > zipkin.jar ACTIVEMQ_URL=tcp://localhost:61616 java -jar zipkin.jar ``` Supercedes #2466 Fixes #1990
|
cc @moekelley76 @Shatakshi26 @vlatk0o @thanhct |
This was referenced Jun 23, 2019
|
TODO: I want to try Amazon MQ to see if anything special is required to support this |
tian-junwei
approved these changes
Jun 23, 2019
this is intentional :) to make sure the default can be changed |
added 2 commits
June 23, 2019 22:46
|
I was able to connect to AWS MQ like this. I think similar to sqs and elasticsearch, we could add a helper in zipkin-aws to generate the config lines. cc @llinder @devinsba ACTIVEMQ_URL='failover:(ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-1.mq.ap-southeast-1.amazonaws.com:61617,ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-2.mq.ap-southeast-1.amazonaws.com:61617)' ACTIVEMQ_USERNAME=zipkin ACTIVEMQ_PASSWORD=zipkin12345678 ACTIVEMQ_CONCURRENCY=8 java -jar ./zipkin-server/target/zipkin-server-*exec.jar --logging.level.zipkin2=DEBUG |
|
I'm very confident in this change. I will merge so easier to try from snapshot and will also post a one-off docker image also. Any feedback post-merge is welcome also. |
|
updated instructions on how to test |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Due to popular demand, this adds support for ActiveMQ 5.x. This is enabled when the env variable `ACTIVEMQ_URL` is set to a valid broker. Thanks very much to @IAMTJW for early work towards this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to popular demand, this adds support for ActiveMQ 5.x.
This is enabled when the env variable
ACTIVEMQ_URLis set to a validbroker. Thanks very much to @IAMTJW for early work towards this change.
Trying this change
This change has been merged, but as of 24 June, not yet released. In order to try this change, you can use jitpack https://jitpack.io/#openzipkin/zipkin or a one-off docker image built from this commit
Ex. simple usage against a local broker
Ex. usage with docker against a remote AWS MQ failover group (using a temporary image)
docker run -d -p 9411:9411 -e ACTIVEMQ_URL='failover:(ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-1.mq.ap-southeast-1.amazonaws.com:61617,ssl://b-da18ebe4-54ff-4dfc-835f-3862a6c144b1-2.mq.ap-southeast-1.amazonaws.com:61617)' -e ACTIVEMQ_USERNAME=zipkin -e ACTIVEMQ_PASSWORD=zipkin12345678 -e ACTIVEMQ_CONCURRENCY=8 adriancole/zipkinSupercedes #2466
Fixes #1990