Makes it an error to store during assembly of a call #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public ThrottledCall(ExecutorService executor, Limiter<Void> limiter, | ||
| Supplier<? extends Call<V>> supplier) { | ||
| final Call<V> delegate; |
There was a problem hiding this comment.
look ma. no volatiles :)
Before this, there was some extra code in the throttle package handling a bug in our in memory storage. This fixes that and removes the extra code. See #2502
codefromthecrypt
force-pushed
the
error-io-on-assembly
branch
from
8300976 to
03b3c69
Compare
|
finally Jenkins is green |
Logic-32
reviewed
May 10, 2019
zipkin-server/src/main/java/zipkin2/server/internal/throttle/ThrottledCall.java
Outdated
Show resolved
Hide resolved
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Before this, there was some extra code in the throttle package handling a bug in our in memory storage. This fixes that and removes the extra code. See openzipkin#2502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, there was some extra code in the throttle package handling
a bug in our in memory storage. This fixes that and removes the extra
code.
See #2502