Simplifies build by bundling Scribe (still disabled by default) #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heh cool :) |
We used to bundle scribe, but due to library conflicts, moved it optional. As Armeria natively supports thrift (incidentally armeria means sea thrift), we no longer have this problem. Bundling removes one of the most complex things from our project for sites that still use Scribe (most folks who use Finagle will).
codefromthecrypt
force-pushed
the
bundle-scribe
branch
from
e131e6d to
dc95f95
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…zipkin#2576) We used to bundle scribe, but due to library conflicts, moved it optional. As Armeria natively supports thrift (incidentally armeria means sea thrift), we no longer have this problem. Bundling removes one of the most complex things from our project for sites that still use Scribe (most folks who use Finagle will).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to bundle scribe, but due to library conflicts, moved it
optional. As Armeria natively supports thrift (incidentally armeria
means sea thrift), we no longer have this problem.
Bundling removes one of the most complex things from our project for
sites that still use Scribe (most folks who use Finagle will).
This adds 1MiB to the server jar, which could be reduced further if
needed by:
I don't think this is worthwhile yet.