Conventionally use RejectedExecutionException for load issues #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the ElasticsearchSpanConsumerTest and the MockWebServer it uses. However, I didn't notice any tests for span indexing to base things off of. So I wrote a more direct HttpBulkIndexerTest to validate this behavior. Does that work? |
|
we can merge on green. as this is a minor change I suspect it isnt blocking on iCLA such as the major refactoring change is.. |
Logic-32
commented
Apr 24, 2019
...-storage/elasticsearch/src/test/java/zipkin2/elasticsearch/internal/HttpBulkIndexerTest.java
Show resolved
Hide resolved
…sts" error and throw more descriptive exception.
codefromthecrypt
force-pushed
the
RejectedExecutionException
branch
from
60bf284 to
b1e119c
Compare
|
thanks. let me know if you want a hand rebasing your other branch/PR |
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Elasticsearch's HttpBulkIndexer to check for "too many requsts" error and throw more descriptive exception.