Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Elasticsearch support for Autocomplete tags #2333

Merged
merged 3 commits into from
Jan 3, 2019

Conversation

codefromthecrypt
Copy link
Member

No description provided.

@codefromthecrypt
Copy link
Member Author

this still needs an auto-complete tag write deduplicator similar to what's in cassandra

@codefromthecrypt codefromthecrypt force-pushed the tags-api-elasticsearch branch 2 times, most recently from 1cbe381 to 6cc5a05 Compare December 18, 2018 06:47
@codefromthecrypt
Copy link
Member Author

made some naming adjustments mostly internal code, but also "tagkey" json field name to "tagKey" @zeagord PTAL! I plan to merge this independent of deduplication code.

Copy link
Member

@zeagord zeagord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except the license year. It's that time of the year :)

@codefromthecrypt codefromthecrypt merged commit 7ca650d into master Jan 3, 2019
@codefromthecrypt codefromthecrypt deleted the tags-api-elasticsearch branch January 3, 2019 10:32
abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants