Brings back relative width in trace query screen #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the trace query screen and reorganizes code to more easily tell which screens need which data from the trace summary.
codefromthecrypt
commented
Nov 1, 2018
| @@ -227,40 +231,32 @@ export function traceSummariesToMustache(serviceName = null, traceSummaries, utc | |||
| return []; | |||
| } else { | |||
| const traceSummariesCleaned = removeEmptyFromArray(traceSummaries); | |||
| const maxDuration = Math.max(...traceSummariesCleaned.map((s) => s.duration)) / 1000; | |||
There was a problem hiding this comment.
this was the bug. all the data are in microseconds, yet somehow this line thought it should be millis :P
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
This fixes a bug in the trace query screen and reorganizes code to more easily tell which screens need which data from the trace summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the trace query screen and reorganizes code to more
easily tell which screens need which data from the trace summary.
Before:
After:
