Removes auto-value dependency and maven metadata from core jar #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2018 08:42
This removes the auto-value dependency from the zipkin2 core jar as we only use it in a couple places now. This prevents a version problem where new versions require a hard dependency. It also reduces the number of classes and the size (orders of tens of kilobytes uncompressed). By default, the maven plugin includes a copy of the pom file, which can be a kilobyte or more of text. This excludes it in favor of normal download location.
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…ipkin#2062) This removes the auto-value dependency from the zipkin2 core jar as we only use it in a couple places now. This prevents a version problem where new versions require a hard dependency. It also reduces the number of classes and the size (orders of tens of kilobytes uncompressed). By default, the maven plugin includes a copy of the pom file, which can be a kilobyte or more of text. This excludes it in favor of normal download location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the auto-value dependency from the zipkin2 core jar as
we only use it in a couple places now. This prevents a version problem
where new versions require a hard dependency. It also reduces the
number of classes and the size (orders of tens of kilobytes
uncompressed).
By default, the maven plugin includes a copy of the pom file, which can
be a kilobyte or more of text. This excludes it in favor of normal
download location.