removes listing dupe tags from UI (only if both key & value are the same #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also issue #989 |
|
looks like the right fix. thanks tons!
might be a mild pain to extract the code such that it can be unit tested..
but mind timeboxing an attempt?
|
|
sure. I'll also fix linter warnings/errors |
codefromthecrypt
approved these changes
Jan 4, 2018
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…ame (openzipkin#1867) * removes listing dupe tags from UI (only if both key and value are the same)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shared spans mode it is easy to wind up with duplicate tags (binary annotations). Some instrumentation has tried to avoid this collision by either removing this information from their client side or server side instrumentation at the expense of losing this information if one of the sides is not instrumented.
By deduping tags in the UI view when both key and value are exactly the same we'll have all information available if one side is not instrumented while only showing dupe tags if client side and server side have different values (which can be valuable information to have and avoids us making an estimated decision on which tags are more important from either client or server side).