Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes v2 IDs and IPs to validated Strings #1721

Merged
merged 2 commits into from
Sep 2, 2017
Merged

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Aug 31, 2017

This changes v2 IDs and IPs to validated Strings, which matches the open api definition http://zipkin.io/zipkin-api/#/

This also polishes codec and backfills the Annotation and Endpoint types missing from the WIP v2 model.

Benchmark results are about 2x efficient as prior:

Benchmark                                          Mode  Cnt   Score   Error  Units
CodecBenchmarks.readClientSpan_json_span2          avgt   15   4.220 ± 0.103  us/op
CodecBenchmarks.readClientSpan_json_zipkin         avgt   15   8.371 ± 0.404  us/op
CodecBenchmarks.readClientSpan_thrift_libthrift    avgt   15   2.020 ± 0.064  us/op
CodecBenchmarks.readClientSpan_thrift_zipkin       avgt   15   2.055 ± 0.051  us/op
CodecBenchmarks.readTenClientSpans_json_span2      avgt   15  29.917 ± 0.969  us/op
CodecBenchmarks.readTenClientSpans_json_zipkin     avgt   15  67.485 ± 2.951  us/op
CodecBenchmarks.readTenClientSpans_thrift_zipkin   avgt   15  21.180 ± 0.816  us/op
CodecBenchmarks.writeClientSpan_json_span2         avgt   15   1.000 ± 0.041  us/op
CodecBenchmarks.writeClientSpan_json_zipkin        avgt   15   1.916 ± 0.048  us/op
CodecBenchmarks.writeClientSpan_thrift_libthrift   avgt   15   2.860 ± 0.092  us/op
CodecBenchmarks.writeClientSpan_thrift_zipkin      avgt   15   0.660 ± 0.029  us/op
CodecBenchmarks.writeTenClientSpans_json_span2     avgt   15  10.249 ± 0.260  us/op
CodecBenchmarks.writeTenClientSpans_json_zipkin    avgt   15  19.509 ± 1.474  us/op
CodecBenchmarks.writeTenClientSpans_thrift_zipkin  avgt   15   6.326 ± 0.081  us/op

See #1499 (comment)

@codefromthecrypt codefromthecrypt force-pushed the string-traceId branch 2 times, most recently from c6fc748 to 5bc51b1 Compare August 31, 2017 11:58
This adds decoupled Annotation and Endpoint variants for v2.

This also fleshes out codec for use in benchmarks, spark and query apis.
@codefromthecrypt codefromthecrypt changed the title Changes v2 trace ID to hex Changes v2 IDs and IPs to validated Strings Sep 2, 2017
@codefromthecrypt codefromthecrypt merged commit 8a33b2a into master Sep 2, 2017
@codefromthecrypt codefromthecrypt deleted the string-traceId branch September 2, 2017 04:48
abesto pushed a commit to abesto/zipkin that referenced this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant