Switches CollectorSampler to use (trace ID, debug) vs Span v1 object #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import static java.util.Arrays.asList; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.ArgumentMatchers.any; |
There was a problem hiding this comment.
converted this to mock because a near future change will make this type abstract
codefromthecrypt
force-pushed
the
refactor-decoder
branch
from
65e22ac to
58f9371
Compare
codefromthecrypt
force-pushed
the
collector-sampler
branch
from
109272d to
d37c3ad
Compare
Currently, transports can decode zipkin2 format, but it has to be converted to v1 objects prior to storage. Part of the reason is CollectorSampler (used for load shedding to protect storage), accepts an object type as opposed to the parameters trace ID and debug. This deprecates the former in favor of the latter, as trace ID and debug exist in both formats. We are switching code to permit use of zipkin2 format in transports.
codefromthecrypt
force-pushed
the
collector-sampler
branch
from
d37c3ad to
d3586f5
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…penzipkin#1697) Currently, transports can decode zipkin2 format, but it has to be converted to v1 objects prior to storage. Part of the reason is CollectorSampler (used for load shedding to protect storage), accepts an object type as opposed to the parameters trace ID and debug. This deprecates the former in favor of the latter, as trace ID and debug exist in both formats. We are switching code to permit use of zipkin2 format in transports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, transports can decode zipkin2 format, but it has to be
converted to v1 objects prior to storage. Part of the reason is
CollectorSampler (used for load shedding to protect storage), accepts
an object type as opposed to the parameters trace ID and debug. This
deprecates the former in favor of the latter, as trace ID and debug
exist in both formats.
We are switching code to permit use of zipkin2 format in transports.