Moves dependency link test to MySQL package #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the MySQL code for dependency linking was not unit tested, rather relying on integration tests. This moves tests that were for MySQL, but stored in core to where they are used.
codefromthecrypt
force-pushed
the
mysql-test
branch
from
c094c70 to
b9298f5
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Before, the MySQL code for dependency linking was not unit tested, rather relying on integration tests. This moves tests that were for MySQL, but stored in core to where they are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the MySQL code for dependency linking was not unit tested,
rather relying on integration tests. This moves tests that were for
MySQL, but stored in core to where they are used.