-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors elasticsearch service and span name query to be like c* #1560
Conversation
e2173ff
to
79f8a9b
Compare
ok code now sends service/span indexes in the same batch command. This should help with AWS transfer charges, especially since we gzip requests. cc @devinsba @semyonslepov still need some code cleanup and other notes in the TODO |
79f8a9b
to
1667945
Compare
backport logic in place. going to give a stab at a backport script as particularly serviceNames being current helps. |
1667945
to
a377dc1
Compare
I think the best way to backport is to sneak hidden feature into zipkin-dependencies (as it is already a spark job and can do everything) |
a669071
to
948de67
Compare
If someone wants to migrate old data, they'd need to do the following. For each span in an index (ex zipkin-2017-02-14/span) id = myServiceName|mySpanName save the unique set of documents to the "servicespan" type in the same index (ex zipkin-2017-02-14/servicespan) |
depends on #1562 |
a90ecd0
to
e188444
Compare
fixed a very silly test setup bug which consumed a lot of my last night.. will be ready to go on green PS ignoring circleci because it thinks the date is different than it is (a routine problem unrelated to this code) |
Service and span names are written to the same daily indexes as spans and dependency links as the document type "servicespan". The document is a simple structure, like: ```json { "serviceName": "MyServiceName", "spanName": "MySpanName", } ``` When the "servicespan" type is missing from an index, or there's no results returned, a fallback nested query is invoked.
e188444
to
7b56546
Compare
Service and span names are written to the same daily indexes as spans
and dependency links as the document type "servicespan".
The document is a simple structure, like:
When the "servicespan" type is missing from an index, or there's no
results returned, a fallback nested query is invoked.
Fixes #1526