Reduces the core jar from 272 to 188k by tuning codec and shade #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Motivation for this is to lower barrier for tracers to include zipkin's standard library without resorting to extracting a separate "model jar" |
| @@ -26,7 +26,7 @@ Check out the [`zipkin-server`](/zipkin-server) documentation for configuration | |||
| ## Core Library | |||
| The [core library](https://github.com/openzipkin/zipkin/tree/master/zipkin/src/main/java/io/zipkin) requires minimum language level 7. While currently only used by the server, we expect this library to be used in native instrumentation as well. | |||
|
|
|||
| This includes built-in codec for both thrift and json structs. Direct dependencies on thrift or moshi (json library) are avoided by minifying and repackaging classes used. The result is a 256k jar which won't conflict with any library you use. | |||
There was a problem hiding this comment.
lie.. we actually crept up to 272K! I wrote in 190, not 188, to give a little room :)
codefromthecrypt
force-pushed
the
minify-more
branch
2 times, most recently
from
916af96 to
b1ecb40
Compare
Before, we used more reflection than necessary in codec. This implied use of larger and more classes than we actually need. By slightly changing codec, and manually controlling shade, we dropped the jar size by 45%.
codefromthecrypt
force-pushed
the
minify-more
branch
2 times, most recently
from
6ed6a3b to
a596e0e
Compare
This reduces load on cassandra test in attempts to help with travis. See #1237
codefromthecrypt
force-pushed
the
minify-more
branch
from
0592849 to
7227f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we used more reflection than necessary in codec. This implied
use of larger and more classes than we actually need. By slightly
changing codec, and manually controlling shade, we dropped the jar size
by 45%.