Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds properties that affect Elasticsearch index scalability #1150

Merged
merged 1 commit into from
Jun 28, 2016

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Jun 27, 2016

This adds the following properties, which help control the scalability
of Zipkin's index in Elasticsearch.

* `ES_INDEX_SHARDS`: The number of shards to split the index into. Each shard and its replicas
                     are assigned to a machine in the cluster. Increasing the number of shards
                     and machines in the cluster will improve read and write performance. Number
                     of shards cannot be changed for existing indices, but new daily indices
                     will pick up changes to the setting. Defaults to 5.
* `ES_INDEX_REPLICAS`: The number of replica copies of each shard in the index. Each shard and
                       its replicas are assigned to a machine in the cluster. Increasing the
                       number of replicas and machines in the cluster will improve read
                       performance, but not write performance. Number of replicas can be changed
                       for existing indices. Defaults to 1. It is highly discouraged to set this
                       to 0 as it would mean a machine failure results in data loss.

@codefromthecrypt
Copy link
Member Author

This came to mind when troubleshooting #1141

@anuraaga PTAL, particularly on the descriptions.

@@ -36,6 +36,24 @@
*/
private String index = "zipkin";


/**
* Affects scalability by limiting the number of nodes in the Elasticsearch cluster that can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in some sense it "limits", I think it's a bit too semantic.

The number of shards to split the index into. Each shard and its replicas are assigned to a machine in the cluster. Increasing the number of shards and machines in the cluster will improve read and write performance. Number of shards cannot be changed for existing indices, but new daily indices will pick up changes to the setting. Defaults to 5.

This adds the following properties, which help control the scalability
of Zipkin's index in Elasticsearch.

    * `ES_INDEX_SHARDS`: The number of shards to split the index into. Each shard and its replicas
                         are assigned to a machine in the cluster. Increasing the number of shards
                         and machines in the cluster will improve read and write performance. Number
                         of shards cannot be changed for existing indices, but new daily indices
                         will pick up changes to the setting. Defaults to 5.
    * `ES_INDEX_REPLICAS`: The number of replica copies of each shard in the index. Each shard and
                           its replicas are assigned to a machine in the cluster. Increasing the
                           number of replicas and machines in the cluster will improve read
                           performance, but not write performance. Number of replicas can be changed
                           for existing indices. Defaults to 1. It is highly discouraged to set this
                           to 0 as it would mean a machine failure results in data loss.
@codefromthecrypt
Copy link
Member Author

updated with better comments thx to @anuraaga

@codefromthecrypt codefromthecrypt merged commit 26368ae into master Jun 28, 2016
@codefromthecrypt codefromthecrypt deleted the es-shards branch June 28, 2016 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants