Uses ES bulk api only when there's more than one span #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @anuraaga |
| if (spans.isEmpty()) return Futures.immediateFuture(null); | ||
|
|
||
| // Create a bulk request when there is more than one span to store | ||
| ListenableFuture<?> future; |
There was a problem hiding this comment.
Recommend final since it's a branched initialization
There was a problem hiding this comment.
sadly can't unless we refactor further due to the later if
(ElasticsearchStorage.FLUSH_ON_WRITES)
There was a problem hiding this comment.
oh.. actually that looks not too bad.. will do
There was a problem hiding this comment.
nope was too bad.. leaving un-final :P
|
LGTM - thanks for fixing (and feel the pain on the difficulty of unit testing ES client...). |
codefromthecrypt
force-pushed
the
one-isnt-bu
branch
from
e4b3c89 to
5ea9850
Compare
During a test where 100 single-span messages are sent to Kafka at the same time, I noticed only 58-97 of them would end up in storage eventhough all messages parsed properly and no operations failed. After a 100ms/message pause was added, the store rate of this test went to 100%, so figured it was some sort of state issue. I noticed the code was using Bulk operations regardless of input size, so as a wild guess changed the special-case single-span messages. At least in this test, it raised the success rate to 100% without any pausing needed. I don't know why this worked, but it seems sensible to not use bulk apis when there's no bulk action to perform. I started to write a unit test to validate single-length lists don't use bulk, but the Mockito involved became too verbose as the Elasticsearch client uses chaining and other patterns that are tedious to mock. Instead, we should make a parallel integration test and apply them to all storage components.
codefromthecrypt
force-pushed
the
one-isnt-bu
branch
from
5ea9850 to
05d5412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a test where 100 single-span messages are sent to Kafka at the
same time, I noticed only 58-97 of them would end up in storage
eventhough all messages parsed properly and no operations failed.
After a 100ms/message pause was added, the store rate of this test went
to 100%, so figured it was some sort of state issue. I noticed the code
was using Bulk operations regardless of input size, so as a wild guess
changed the special-case single-span messages. At least in this test, it
raised the success rate to 100% without any pausing needed.
I don't know why this worked, but it seems sensible to not use bulk apis
when there's no bulk action to perform.
I started to write a unit test to validate single-length lists don't use
bulk, but the Mockito involved became too verbose as the Elasticsearch
client uses chaining and other patterns that are tedious to mock.
Instead, we should make a parallel integration test and apply them to
all storage components.
See #1141