Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for local development #114

Closed
wants to merge 1 commit into from
Closed

Update docs for local development #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions zipkin-finatra/config/web-dev.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,14 @@ new ZipkinWebConfig {

/**
* Making changes to js/css can be painful with a packaged jar since a compilation is needed to
* repackage any new changes. `resourcePathPrefix` can be hacked to point to the directory
* on your local file system so the browser resolves it outside of the jar. Example:
* repackage any new changes.
* A simple hack is to stand up a simple Python HTTP server and point `resourcePathPrefix` it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we can do to avoid this step? Seems annoying that we'd require a third party http server for just that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to Johan IRL about this. The python server is just nice to have if you're doing JS/CSS development since the resources get packaged in the jar and won't be refreshed without a full compile; it's not necessary to run the Scala UI.

* Example:
*
* `val resourcePathPrefix = "file:///Users/username/path/to/zipkin-finatra/src/main/resources/public"`
* `cd zipkin-finatra/src/main/resources/public && python -m SimpleHTTPServer`
*
* Then, set:
* `val resourcePathPrefix = "http://localhost:8000"`
*/
val resourcePathPrefix = "/public"
jsConfig = new JsConfig {
Expand Down