Two separate bugfixes. #1120
Merged
Two separate bugfixes. #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NegatioN
commented
May 26, 2016
NegatioN
commented
- Bugfix goToTrace not triggering on other pages than default, creating a malformed url.
- webpack devproxy only targeted default-page locally, and got resources from upstream api if you attached an external dev-server. The external zipkin-server can now be configured with an environment-variable.
1. Bugfix goToTrace not triggering on other pages than default, creating a malformed url. 2. webpack devproxy only targeted default-page locally, and got resources from upstream api if you attached an external dev-server. The external zipkin-server can now be configured with an environment-variable.
|
thanks! mind putting in the README how to connect to an existing zipkin server (ex via docker or some other specified ip)? |
|
I'm not sure if this is exactly what you were looking for. Please give me a shout if it wasn't. :) |
|
|
|
Thanks! |
|
Heh. Ran into this today when I tried to modify the UI, if only if I had seen it before my flight... |
|
What one can synchronise before a flight is indeed important!
|
|
Flight attendants should remind people to git pull as part of the preflight instructions... |
|
nice once :)
|
codefromthecrypt
pushed a commit
that referenced
this pull request
Jun 3, 2016
* Two separate bugfixes. 1. Bugfix goToTrace not triggering on other pages than default, creating a malformed url. 2. webpack devproxy only targeted default-page locally, and got resources from upstream api if you attached an external dev-server. The external zipkin-server can now be configured with an environment-variable. * update readme with proxy backend-info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.