Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZipkinSpec doesn't tear down zookeeper instance #22

Closed
franklinhu opened this issue Jun 13, 2012 · 2 comments
Closed

ZipkinSpec doesn't tear down zookeeper instance #22

franklinhu opened this issue Jun 13, 2012 · 2 comments

Comments

@franklinhu
Copy link
Contributor

When running tests for zipkin server, the ZipkinSpec doesn't close the ZK instance that's started. This causes another run of the tests to fail since the ZK instance is still bound to the port.

To reproduce:

  $ bin/sbt
  > test // this may pass
  > ...
  > test // ZipkinSpec will fail
@franklinhu
Copy link
Contributor Author

Also we may want to consider using this to stand up the ZK instance: http://twitter.github.com/commons/apidocs/com/twitter/common/zookeeper/testing/ZooKeeperTestServer.html

@franklinhu
Copy link
Contributor Author

Fixed in #23

codefromthecrypt pushed a commit that referenced this issue Jun 3, 2016
@adriancole
Merge pull request #22 from openzipkin/adrian.cleanups
3cfe854 
Converged maven wrapper, fixed docker and compile fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franklinhu