Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display subsequent children on same line in UI. #1701

Open
kyleu opened this issue Aug 23, 2017 · 4 comments
Open

Option to display subsequent children on same line in UI. #1701

kyleu opened this issue Aug 23, 2017 · 4 comments
Labels

Comments

@kyleu
Copy link

kyleu commented Aug 23, 2017

Currently, the UI displays each child on a new line.

┌─────┐ ┌───────────────────────────────────────────────────────┐
│  A  │ │░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░│
│     │ │░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░│
└─────┘ └───────────────────────────────────────────────────────┘
┌─────┐    ┌─────────────────────┐                               
│     │    │░░░░░░░░░░░░░░░░░░░░░│                               
│  B  │    └─────────────────────┘                               
│     │                                ┌─────────┐               
│     │                                │░░░░░░░░░│               
└─────┘                                └─────────┘

In the case of two spans from the same service that do not overlap temporally, a potential UI optimization would be displaying them on the same line.

┌─────┐ ┌───────────────────────────────────────────────────────┐
│  A  │ │░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░│
│     │ │░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░│
└─────┘ └───────────────────────────────────────────────────────┘
┌─────┐    ┌─────────────────────┐      ┌─────────┐              
│  B  │    │░░░░░░░░░░░░░░░░░░░░░├─────▶│░░░░░░░░░│              
└─────┘    └─────────────────────┘      └─────────┘

(charts by @adriancole)

Related: opentracing.io supports "FollowFrom", to allow the second B span to have A as a parent while still relating to B1.

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Aug 23, 2017 via email

@codefromthecrypt
Copy link
Member

Spoke with @garyd203 and @SirTyro here at Tyro. Right now, in lieu of this, they are cleverly propagating send timestamp, then on the receiver side adding that as an annotation on the child span. Ends up looking like a dot followed by a bar thereafter. Being on the same line helps you know visibly where it started.

In mapping producer/consumer, still think single-line could work. If consumer span is solely for consuming (not processing), the processor child could also be on the same line.

Might also be nice if you can click on possibly a dashed line or something between producer and consumer to give a view similar to the span detail pane (except showing all points of time between the producer and consumer)

@jbaris
Copy link

jbaris commented Feb 27, 2022

This will be a great feature. I saw signoz has this feature, it's called "Trace Graph"

image

I think is very useful to get the big picture of your request. Then you can use the tree graph for details.

@jcchavezs
Copy link
Contributor

jcchavezs commented Mar 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants