-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to display subsequent children on same line in UI. #1701
Comments
thanks for raising this! one note to bear in mind that unless we change the
entire layout a "follows from" that crosses services (aka a
producer/consumer) would be indistinguishable from a step child. that's
because depth also is how we tag a span with a service.
Another side note is that producer/consumer span kind in zipkin is imho a
bit more semantically useful than "follows from", as it implies the same
which is that the producer doesn't rely on the outcome of the consumer.
there are probably hairs to split here, but anyway worth mentioning how we
handle things.
|
Spoke with @garyd203 and @SirTyro here at Tyro. Right now, in lieu of this, they are cleverly propagating send timestamp, then on the receiver side adding that as an annotation on the child span. Ends up looking like a dot followed by a bar thereafter. Being on the same line helps you know visibly where it started. In mapping producer/consumer, still think single-line could work. If consumer span is solely for consuming (not processing), the processor child could also be on the same line. Might also be nice if you can click on possibly a dashed line or something between producer and consumer to give a view similar to the span detail pane (except showing all points of time between the producer and consumer) |
Ping @tacigar
søn. 27. feb. 2022, 13:45 skrev Juan Ignacio Barisich <
***@***.***>:
… This will be a great feature. I saw signoz has this feature, it's called
"Trace Graph"
[image: image]
<https://user-images.githubusercontent.com/819587/155882830-7aa5e74f-61a6-4410-aa30-f9de16eed4f7.png>
I think is very useful to get the big picture of your request. Then you
can use the tree graph for details.
—
Reply to this email directly, view it on GitHub
<#1701 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYATBWZLC7ZXNJSSQPUDU5IMFJANCNFSM4DX5ST2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Currently, the UI displays each child on a new line.
In the case of two spans from the same service that do not overlap temporally, a potential UI optimization would be displaying them on the same line.
(charts by @adriancole)
Related: opentracing.io supports "FollowFrom", to allow the second B span to have A as a parent while still relating to B1.
The text was updated successfully, but these errors were encountered: