Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON button to trace detail view #1060

Closed
codefromthecrypt opened this issue Mar 23, 2016 · 1 comment
Closed

Add JSON button to trace detail view #1060

codefromthecrypt opened this issue Mar 23, 2016 · 1 comment

Comments

@codefromthecrypt
Copy link
Member

The screenshot on zipkin.io includes a blue JSON button which is a link to /api/v1/trace/id. This would be very helpful when folks are trying to debug problems, as manually instructing is not intuitive.
@eirslett
Copy link
Contributor

It should be possible to add this in trace.mustache, I think.
Something like <a href="/api/v1/trace/{{traceId}}">JSON</a>

@codefromthecrypt codefromthecrypt mentioned this issue Apr 22, 2016
Closed
@codefromthecrypt codefromthecrypt mentioned this issue May 14, 2016
Closed
@virtuald virtuald mentioned this issue May 28, 2016
Merged
codefromthecrypt pushed a commit that referenced this issue Jun 1, 2016
@virtuald @adriancole
Adds JSON button to trace page
0976ca5 
- Shows prettified JSON in modal dialog
- Adds download link for JSON

Fixes #1060
codefromthecrypt pushed a commit that referenced this issue Jun 3, 2016
@virtuald @adriancole
Adds JSON button to trace page
b81fcc9 
- Shows prettified JSON in modal dialog
- Adds download link for JSON

Fixes #1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codefromthecrypt @eirslett