Skip to content

Commit

Permalink
Misc finatra fixes
Browse files Browse the repository at this point in the history
- Fix span details modal on static trace page
- Remove unnecessary code
- Sort span annotations by timestamp when dumping to json

Author: @franklinhu
Fixes #80
URL: #80
  • Loading branch information
Franklin Hu committed Jul 23, 2012
1 parent f417c9a commit b053a9e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
10 changes: 0 additions & 10 deletions zipkin-finatra/src/main/resources/templates/show.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,6 @@
<div id="annotation-modal" class="trace-desc-body annotation-list modal">
</div>

<div class="modal hide" id="export-trace-modal">
<div class="modal-header">
<a class="close" data-dismiss="modal" href="#export-trace-modal">×</a>
<h3>Keep this JSON data somewhere safe</h3>
</div>
<div class="modal-body">
<p id="export-trace-data"></p>
</div>
</div>

<script type="text/javascript">
$(document).ready(function() {
{{inlineJs}}
Expand Down
3 changes: 3 additions & 0 deletions zipkin-finatra/src/main/resources/templates/static.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
</div>
</div>

<div id="annotation-modal" class="trace-desc-body annotation-list modal">
</div>

<script type="text/javascript">
$(document).ready(function() {
{{inlineJs}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ object JsonAdapter extends Adapter {
s.serviceNames,
s.firstAnnotation.get.timestamp,
s.duration.get,
s.annotations,
s.annotations.sortWith((a,b) => a.timestamp < b.timestamp),
s.binaryAnnotations.map(JsonAdapter(_)))
}

Expand Down

0 comments on commit b053a9e

Please sign in to comment.